worked out bugs in the module install and community service add

venice-data/scripts/comm/admin/svc_add.js

@@ -50,6 +50,7 @@ if (csd==null)
 
 // Now add the service!
 comm.addService(user,req,csd.name.namespace,csd.name.name);
+vlib.forceReloadMenu(req);
 
 // Bounce back to the services list.
-dynamo.scriptOutput(new Redirect("SERVLET","comm/admin/services.js.vs"));
+dynamo.scriptOutput(new Redirect("SERVLET","comm/admin/services.js.vs?cc=" + comm.getCID()));

venice-data/scripts/comm/admin/svc_remove.js

@@ -52,18 +52,19 @@ rc = null;
 if (vlib.confirmed(req,"/comm/admin/svc_remove.js.vs","confirmation","confnum"))
 { // remove the service!
   comm.removeService(user,req,csd.name.namespace,csd.name.name);
-  rc = new Redirect("SERVLET","comm/admin/services.js.vs");
+  vlib.forceReloadMenu(req);
+  rc = new Redirect("SERVLET","comm/admin/services.js.vs?cc=" + comm.getCID());
 
 } // end if
 else
 { // create the confirmation dialog
-  msg = "You are about to remove the service " + csd.name.namespace + "::" + csd.name.name + " from the community '"
-      + comm.name + "'!  This may cause any and all data associated with this service in the community (such as "
-      + "database table contents) to be <b>DESTROYED AND IRREVOCABLY LOST!</b> Are you <em>really</em> sure you "
-      + "want to do this?";
+  msg = "You are about to remove the service " + stringutils.encodeHTML(csd.name.namespace) + "::"
+      + stringutils.encodeHTML(csd.name.name) + " from the community '" + stringutils.encodeHTML(comm.name)
+      + "'!  This may cause any and all data associated with this service in the community (such as database table "
+      + "contents) to be <b>DESTROYED AND IRREVOCABLY LOST!</b> Are you <em>really</em> sure you want to do this?";
   rc = new ConfirmBox(req,"/comm/admin/svc_remove.js.vs","confirmation","confnum","Service Remove Confirmation",msg,
                       "SERVLET","comm/admin/svc_remove.js.vs?cc=" + comm.getCID() + "&id=" + ndx,"SERVLET",
-                      "comm/admin/services.js.vs");
+                      "comm/admin/services.js.vs?cc=" + comm.getCID());
 
 } // end else
 

venice-data/scripts/comm/unjoin.js

@@ -36,6 +36,7 @@ if (vlib.confirmed(req,"/comm/unjoin.js.vs","confirmation","confnum"))
 
 } // end if
 
-dynamo.scriptOutput(new ConfirmBox(req,"/comm/unjoin.js.vs","confirmation","confnum","Unjoin Confirmation",
-		    "You are about to unjoin the '" + comm.name + "' community!  Are you sure you want to do this?",
+msg = "You are about to unjoin the '" + stringutils.encodeHTML(comm.name) + "' community!  Are you sure you want "
+    + "to do this?";
+dynamo.scriptOutput(new ConfirmBox(req,"/comm/unjoin.js.vs","confirmation","confnum","Unjoin Confirmation",msg,
                     "SERVLET","comm/unjoin.js.vs?cc=" + comm.getCID(),"SERVLET","community/" + comm.alias));

venice-data/scripts/sysadmin/module_uninstall.js

@@ -37,12 +37,14 @@ if (!(acl.testPermission(user,VeniceNamespaces.SYSTEM_PERMS_NAMESPACE,"uninstall
 
 modops = cast.queryModuleOperations(req);
 
-the_module = rhelp.getParameterString("mod");
+the_module = req_help.getParameterString("mod");
 if (the_module!=null)
 { // we want to uninstall this module
+  logger.debug("Want to uninstall " + the_module);
   rc = null;
   if (vlib.confirmed(req,"/sysadmin/module_uninstall.js.vs","confirmation","confnum"))
   { // OK, they have confirmed they want to uninstall the module...do it!
+    logger.debug("confirmed - do the uninstall!");
     mod = modops.findModuleByFilename(n);
     except = null;
     log = new SimpleMemoryLog();
@@ -68,9 +70,10 @@ if (the_module!=null)
   } // end if
   else
   { // generate a confirmation number box
-    msg = "You are about to uninstall module '" + the_module + "'!  This will cause any and all data associated with "
-        + "this module (such as database tables and their contents) to be <b>DESTROYED AND IRREVOCABLY LOST!</b> "
-        + "Are you <em>really</em> sure you want to do this?";
+    logger.debug("need confirmation number");
+    msg = "You are about to uninstall module '" + stringutils.encodeHTML(the_module) + "'!  This will cause any and "
+        + "all data associated with this module (such as database tables and their contents) to be <b>DESTROYED AND "
+        + "IRREVOCABLY LOST!</b> Are you <em>really</em> sure you want to do this?";
     ok_url = "sysadmin/module_uninstall.js.vs?mod=" + stringutils.encodeURL(the_module);
     rc = new ConfirmBox(req,"/sysadmin/module_uninstall.js.vs","confirmation","confnum",
                         "Module Uninstall Confirmation",msg,"SERVLET",ok_url,"SERVLET",

venice-data/velocity/comm/admin/services.vm

@@ -20,7 +20,7 @@
     community = Community we're displaying the services of.
     services  = List of all available services, with an indication as to whether we're using them.
 *#
-#header2( "Community Services", $community.Name )
+#header2( "Community Services" $community.Name )
 <p><a href="#formatURL( "SERVLET" "comm/admin/main.js.vs" )">Return to Previous Menu</a></p>
 #if( $services.isEmpty() )
   <p><em>There are no community-level services currently defined.</em></p>

venice-data/velocity/sysadmin/module_install.vm

@@ -28,7 +28,7 @@
   to install it.</p>
   <div align="left"><table border="0" cellpadding="0" cellspacing="2">
     #foreach( $m in $modlist )
-      #set( $em = "#encodeURL( $m )"
+      #set( $em = "#encodeURL( $m )" )
       <tr><td class="content">
         <a href="#formatURL( "SERVLET" "sysadmin/module_install.js.vs?mod=$em" )">#encodeHTML( $m )</a>
       </td></tr>

venice-data/velocity/sysadmin/module_install_result.vm

@@ -35,5 +35,5 @@
     #encodeHTML( $x )<br />
   #end
 </td></tr></table>
-<p><a href="sysadmin/module_install.js.vs">Install more modules</a></p>
-<p><a href="sysadmin/modules.js.vs">Return to previous menu</a></p>
+<p><a href="#formatURL( "SERVLET" "sysadmin/module_install.js.vs" )">Install more modules</a></p>
+<p><a href="#formatURL( "SERVLET" "sysadmin/modules.js.vs" )">Return to previous menu</a></p>

venice-data/velocity/sysadmin/module_uninstall_result.vm

@@ -35,5 +35,5 @@
     #encodeHTML( $x )<br />
   #end
 </td></tr></table>
-<p><a href="sysadmin/module_uninstall.js.vs">Uninstall more modules</a></p>
-<p><a href="sysadmin/modules.js.vs">Return to previous menu</a></p>
+<p><a href="#formatURL( "SERVLET" "sysadmin/module_uninstall.js.vs" )">Uninstall more modules</a></p>
+<p><a href="#formatURL( "SERVLET" "sysadmin/modules.js.vs" )">Return to previous menu</a></p>