From e10cf0b48c1901832cb24a9d5d57bb2e9755eb2c Mon Sep 17 00:00:00 2001 From: Amy Gale Ruth Bowersox Date: Tue, 10 Mar 2026 22:11:44 -0600 Subject: [PATCH] logging tested, so tick that off the list --- TODO.md | 2 +- config/config.go | 2 +- logging.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/TODO.md b/TODO.md index 2ff77fc..f15cd82 100644 --- a/TODO.md +++ b/TODO.md @@ -10,7 +10,7 @@ After the point where it reaches feature parity with Venice circa 2006. * ~~Gitea-like status page showing Go-specific internals.~~ * Build static Tailwind CSS file rather than using remote-loaded version. (Gate on debug/prod flag) * Rate limiter. -* Better logging configuration. +* ~~Better logging configuration.~~ ## Immediate Cleanups Required diff --git a/config/config.go b/config/config.go index 416cb94..6fa2d96 100644 --- a/config/config.go +++ b/config/config.go @@ -40,7 +40,7 @@ type AmCLI struct { ConfigFile string `arg:"-C,--config,env:AMSTERDAM_CONFIG" help:"Location of the configuration file."` Debug bool `arg:"-D,--debug,env:AMSTERDAM_DEBUG" help:"Force Amsterdam to run in debug mode."` LogLevel string `arg:"-L,--level,--loglevel,env:AMSTERDAM_LOG_LEVEL" help:"Set the log level for the server."` - Production bool `arg:"-P,--prod,--production,env:AMSTERDAM_PROD" help:"Force Amsterdam to run in production mode."` + Production bool `arg:"-P,--production,env:AMSTERDAM_PROD" help:"Force Amsterdam to run in production mode."` DatabaseURL string `arg:"-d,--database,env:AMSTERDAM_DATABASE_URL" help:"Database URL for Amsterdam to connect to."` Listen string `arg:"-l,--listen,env:AMSTERDAM_LISTEN" help:"Specifies the local address and port for Amsterdam to listen on."` DebugPanic bool `arg:"--debug-panic" help:"Development Only - disable Echo panic recovery"` diff --git a/logging.go b/logging.go index 2668b92..7b71206 100644 --- a/logging.go +++ b/logging.go @@ -286,7 +286,7 @@ func (lf *amLogFile) tryRotate() { if lf.curSize >= lf.maxSize { err := lf.rotate() if err != nil { - log.Error("log rotation failed") + //log.Error("log rotation failed") } } }