amy/amsterdam
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

further optimized database calls to replace all single-value QueryRowContext calls with GetContext

Browse Source
This commit is contained in:
Amy G. Bowersox
2026-02-23 18:21:38 -07:00
parent 4113ba2fca
commit 220e1ecc98
14 changed files with 233 additions and 290 deletions
Download Patch File Download Diff File Expand all files Collapse all files
database/globals.go
+3 -6
View File
@@ -108,8 +108,7 @@ func AmGlobals(ctx context.Context) (*Globals, error) {
defer globalsMutex.Unlock()
if theGlobals == nil {
var g Globals
err := amdb.GetContext(ctx, &g, "SELECT * FROM globals")
if err != nil {
if err := amdb.GetContext(ctx, &g, "SELECT * FROM globals"); err != nil {
return nil, err
}
theGlobals = &g
@@ -146,8 +145,7 @@ func AmGetGlobalProperty(ctx context.Context, index int32) (string, error) {
var err error = nil
rc, ok := globalProps[index]
if !ok {
row := amdb.QueryRowContext(ctx, "SELECT data FROM propglobal WHERE ndx = ?", index)
err = row.Scan(&rc)
err := amdb.GetContext(ctx, &rc, "SELECT data FROM propglobal WHERE ndx = ?", index)
switch err {
case nil:
globalProps[index] = rc
@@ -172,9 +170,8 @@ func AmSetGlobalProperty(ctx context.Context, index int32, value string) error {
defer globalPropMutex.Unlock()
_, updateMode := globalProps[index]
if !updateMode {
row := amdb.QueryRowContext(ctx, "SELECT data FROM propglobal WHERE ndx = ?", index)
var tmpdata string
err := row.Scan(&tmpdata)
err := amdb.GetContext(ctx, &tmpdata, "SELECT data FROM propglobal WHERE ndx = ?", index)
switch err {
case nil:
updateMode = true